Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-905): update endpoint use cases #1020

Merged
merged 60 commits into from
Oct 10, 2024

Conversation

yarex-4chain
Copy link
Contributor

@yarex-4chain yarex-4chain commented Jul 1, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@yarex-4chain yarex-4chain self-assigned this Jul 1, 2024
@yarex-4chain yarex-4chain requested a review from a team as a code owner July 1, 2024 16:38
Copy link

github-actions bot commented Jul 1, 2024

Manual Tests

πŸ’š Manual testing by @dzolt-4chain resulted in success.

@wregulski wregulski self-assigned this Aug 23, 2024
Copy link
Contributor Author

@yarex-4chain yarex-4chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm assuming that the search and admin endpoints will be changed in a follow-up request?

I would approve but it seems that I can't because I'm the original PR author :)

@wregulski
Copy link
Contributor

LGTM - I'm assuming that the search and admin endpoints will be changed in a follow-up request?

I would approve but it seems that I can't because I'm the original PR author :)

Yes, I aim to add it right after the task to add search to contacts and to transactions (it's in separated task).

@pawellewandowski98 pawellewandowski98 added the tested PR was tested by a team member label Aug 28, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/access-key.ts Outdated Show resolved Hide resolved
examples/get-shared-config.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
src/query/query-builder.ts Outdated Show resolved Hide resolved
src/query/query-builder.ts Outdated Show resolved Hide resolved
src/index.test.ts Show resolved Hide resolved
src/index.test.ts Show resolved Hide resolved
wregulski and others added 17 commits October 8, 2024 10:38
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
Co-authored-by: Nazarii-4chain <150656925+Nazarii-4chain@users.noreply.github.com>
@dorzepowski dorzepowski removed the tested PR was tested by a team member label Oct 8, 2024
@dzolt-4chain dzolt-4chain added the tested PR was tested by a team member label Oct 10, 2024
@wregulski wregulski added javascript Pull requests that update Javascript code and removed javascript Pull requests that update Javascript code labels Oct 10, 2024
@wregulski wregulski merged commit 838c389 into main Oct 10, 2024
5 checks passed
@wregulski wregulski deleted the feat/SPV-905-update-endpoint-use-cases branch October 10, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants